errors: add error handler for community submission closed #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
anikachurilova
commented
Aug 8, 2024
anikachurilova
commented
- closes Communities: only members can submit CERNDocumentServer/cds-rdm#158
slint
reviewed
Aug 8, 2024
| class RecordSubmissionClosedCommunityError(PermissionDenied): | ||
| """Record submission policy forbids non-members from submitting records to community.""" | ||
|
|
||
| description = "Submission to this community is only allowed to community members." |
There was a problem hiding this comment.
minor: invenio-records-resources is too low in the dependency chain to know about communities. Shouldn't this be in a module further up the chain?
There was a problem hiding this comment.
+1 for this, there shouldn't be any references to communities in the records-resources modules, since communities depends on records-resources, not the other way around
There was a problem hiding this comment.
Moved changes to inveniosoftware/invenio-rdm-records#1790
closing this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.